Feat: add post render hook #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still need to ship our own math renderer to render `math_` tokens, so let's avoid using two different renderers in the same implementation
We migrate the math parsing responsibility to the MarkdownIt parser. Any element matching `.math` will be rendered using the typesetter. We add `markdown-it-dollarmath` to perform math parsing of $-math
Feat: remove unneeded math wrappers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some lifecycle hooks and makes the math parsing a responsibility of MarkdownIt. We still use the
ILatexTypesetterinterface for typesetting, but this is done explicitly as a post-Markdown rendering transformation.New Features:
IPluginProvider.rank: order of plugin registration, ascending (default 100)IPluginProvider.postRenderHook: provider ofIPostRendererobjectIPluginProvider.preParseHook: provider ofIPreParserobjectIPostRenderer:IPostRenderer.rank: order of callback, ascending (default 100)IPostRenderer.postRender: callback after rendering to HTML is completeIPreParser:IPreParser.rank: order of callback, ascending (default 100)IPreParser.preParser: callback before parsing is performed. Transforms the parsed text.