Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Node 20 compatibility #2

Closed
wants to merge 3 commits into from
Closed

fix Node 20 compatibility #2

wants to merge 3 commits into from

Conversation

turadg
Copy link

@turadg turadg commented Dec 5, 2023

Spawned from Agoric/agoric-sdk#8365 (comment)

I hit my timebox on this for now so just leaving some notes.

make is failing with,

/Users/turadg/Library/Caches/node-gyp/20.9.0/include/node/v8-maybe.h:106:45: error: no template named 'is_lvalue_reference_v' in namespace 'std'; did you mean 'is_lvalue_reference'?
  template <class U, std::enable_if_t<!std::is_lvalue_reference_v<U>>*>
                                       ~~~~~^~~~~~~~~~~~~~~~~~~~~
                                            is_lvalue_reference

electron/electron#35193 has some leads but none have solved it yet.

Maybe Wandalen#53 will solve this before we get back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant