fix: do not shadow clientCtx in start.go (backport cosmos#14086) (cos…

…mos#14101)

* fix: do not shadow clientCtx in start.go (cosmos#14086)

(cherry picked from commit f96072d)

# Conflicts:
#	server/start.go

* updates

Co-authored-by: Julien Robert <julien@rbrt.fr>

server/start.go

@@ -397,6 +397,8 @@ func startInProcess[T types.Application](svrCtx *Context, svrCfg serverconfig.Co
 	// service if API or gRPC is enabled, and avoid doing so in the general
 	// case, because it spawns a new local tendermint RPC client.
 	if (config.API.Enable || config.GRPC.Enable) && tmNode != nil {
+		// re-assign for making the client available below
+		// do not use := to avoid shadowing clientCtx
 		clientCtx = clientCtx.WithClient(local.New(tmNode))
 
 		app.RegisterTxService(clientCtx)