fix(CI): add golangci-lint to dependencies (cosmos#10112) (cosmos#10172)

* fix(CI): add golangci-lint to dependencies (cosmos#10112)

* fix(CI): add golangci-lint to dependencies

* update github workflow

* tidy go.mod

* add missing entries to go.mod

* update deps

* add missing run command

* remove golint and use revive instead

* fix workflow setup

* lint only changed files

* gofmt go tags

* update comments

* make lint-go

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* Update .golangci.yml

* Update .golangci.yml

* fix go.mod

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

.github/workflows/lint.yml

@@ -14,37 +14,18 @@ jobs:
  name: golangci-lint
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@v4
- - uses: actions/setup-go@v5
+ - uses: actions/setup-go@v2.1.4
  with:
- go-version: "1.23"
- check-latest: true
- - uses: technote-space/get-diff-action@v6.1.2
+ go-version: 1.16
+ - uses: technote-space/get-diff-action@v5
  id: git_diff
  with:
  PATTERNS: |
- **/*.mk
- Makefile
- **/Makefile
- .golangci.yml
- - name: Get rocksdb version
- run: ./.github/scripts/get-rocksdb-version.sh
- - name: Fix permissions for cache
- run: sudo chown $(whoami) /usr/local/lib /usr/local/include
- - name: Restore rocksdb libraries cache
- id: cache-rocksdb
- uses: actions/cache/restore@v4
- with:
- path: |
- /usr/local/lib/librocksdb.*
- /usr/local/include/rocksdb
- key: ${{ runner.os }}-rocksdb-${{ env.ROCKSDB_VERSION }}-amd64
- - name: Install rocksdb deps
- run: ./.github/scripts/install-rocksdb-deps.sh
- - name: Install rocksdb
- if: steps.cache-rocksdb.outputs.cache-hit != 'true'
- run: ./.github/scripts/install-rocksdb.sh
- - name: run linting (long)
+ **/**.go
+ go.mod
+ go.sum
+ - name: run go linters
+ run: make lint-go
  if: env.GIT_DIFF
  id: lint_long
  run: |

.golangci.yml

@@ -17,15 +17,17 @@ linters:
  - gci
  - goconst
  - gocritic
- - gofumpt
+ - gofmt
+ - goimports
  - gosec
  - gosimple
  - govet
  - ineffassign
  - misspell
  - nakedret
- - nolintlint
+ - prealloc
  - revive
+ - exportloopref
  - staticcheck
  - stylecheck
  - thelper