Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removed newAccount param from setupWallet #48

Merged
merged 1 commit into from
Jun 10, 2024
Merged

refactor: removed newAccount param from setupWallet #48

merged 1 commit into from
Jun 10, 2024

Conversation

frazarshad
Copy link
Collaborator

Motivation and context

This PR updates the params of the setupWallet command and removes the newAccount field.
This field is being removed because:

  • it serves a function similar to the default behaviour of setupWallet
  • its naming clashes with the createNewWallet param

Does it fix any issue?

#47

@frazarshad frazarshad merged commit c366257 into dev Jun 10, 2024
2 checks passed
@frazarshad frazarshad deleted the refactor/remove-new-account branch June 10, 2024 11:50
@rabi-siddique rabi-siddique mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabi-siddique rabi-siddique rabi-siddique approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frazarshad @rabi-siddique