draw time signature #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agourlay
approved these changes
Feb 22, 2025
agourlay
reviewed
Feb 22, 2025
src/ui/canvas_measure.rs
Outdated
| color: Color::WHITE, | ||
| size: 19.into(), | ||
| font: Font { | ||
| weight: iced::font::Weight::Semibold, |
There was a problem hiding this comment.
this looks a bit heavy for my taste, I'd prefer a Normal font weight
agourlay
reviewed
Feb 22, 2025
src/ui/canvas_measure.rs
Outdated
| let tempo_text = Text { | ||
| content: format!("{numerator}\n{denominator}"), | ||
| color: Color::WHITE, | ||
| size: 19.into(), |
There was a problem hiding this comment.
Is it possible to make it a tad smaller. Like 17 maybe?
agourlay
reviewed
Feb 22, 2025
src/ui/tablature.rs
Outdated
| @@ -43,8 +43,22 @@ impl Tablature { | |||
| let track = &self.song.tracks[self.track_id]; | |||
| let measures = track.measures.len(); | |||
| for i in 0..measures { | |||
| let measure_header = &self.song.measure_headers[i]; | |||
| let previous_measure_header = if i > 0 { | |||
| Some(&self.song.measure_headers[i - 1]) | |||
There was a problem hiding this comment.
Suggested change
| Some(&self.song.measure_headers[i - 1]) | |
| &self.song.measure_headers.get(i - 1) |
|
You need to run |
decrease time signature size run cargo fmt use getter method
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR implements #20.
Key points:
Sample of a song with many time changes.
Samples of 4, 5, 6, and 8 strings
