What is the reasoning for a Request FSA with error flag? (vs a Failure FSA)

[barrystaes]

As i understand now - when a REQUEST FSA gets fired, this can result in a:

• REQUEST FSA with error flag (for example when the API request cant be made)
• SUCCESS FSA (for example for API response 200 OK)
• FAILURE FSA (for example for API response 404 Not Found)

But in my view one REQUEST FSA should result in (only and) exactly one FSA, either SUCCESS or FAILURE.

I haven't actually used it, but i dont really understand the first one. Whats the argument for not returning a FAILURE FSA in that case?

[agraboso]

@barrystaes This is an issue that I struggled with — see this comment of mine. The solution that I came up with might not be to everyone's taste nor even the most logical one. I think a thorough discussion is in order before we push out a v2.

[agraboso]

Pinging #26, since it is relevant to this issue.

[aris-b]

I am also confused. When I get an API request error like this :

{ 
 [RequestError: request to https://xxxxx failed, reason: self signed certificate]
 name: 'RequestError',
 message: 'request to https://xxxx failed, reason: self signed certificate' },
 meta: undefined,
 error: true }

The FAILURE FSA is not triggered. I see this error by logging on REQUEST FSA.
So my question is, when actually FAILURE FSA gets triggered ?

[danludwig]

Found this when searching for how to customize the action payload when a REQUEST FSA is dispatched with an error flag. Seems you can't? For example, if I attach a key property to the initial REQUEST payload, there is no way to correlate that key's value back to the request that failed?

[barrystaes]

So my question is, when actually FAILURE FSA gets triggered ?

@aris-b a FAILURE FSA is triggered when the response is not 200 OK, and if the response was 200 OK expect a SUCCESS FSA.
If the request could not be made at all, expect a REQUEST FSA with error:true. This behavior is documented at lifecycle in readme.md and its also outlined in the first post of this issue..

@danludwig Have you looked into using the meta property, which is there for the purpose of adding metadata to use later.

[iamandrewluca]

Fixed in #175