Skip to content

Commit

Permalink
Fix broken specs from EMS hostname validation
Browse files Browse the repository at this point in the history
ManageIQ/manageiq#16714 Caused the specs which
use invalid hostnames to fail in different ways then expected.  The test
checking for nil ems hostname is now invalid because that isn't possible
and the other changed the hostname to something with a space which can
be replaced with a '-'
  • Loading branch information
agrare committed Jan 12, 2018
1 parent 13b3f6a commit 621a19f
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions spec/models/manageiq/providers/vmware/infra_manager_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,6 @@
expect(@ems.remote_console_vmrc_support_known?).to be_truthy
end

it "false for missing hostname" do
@ems.update_attributes(:hostname => nil, :api_version => "5.0", :uid_ems => "2E1C1E82-BD83-4E54-9271-630C6DFAD4D1")
expect(@ems.remote_console_vmrc_support_known?).not_to be_truthy
end

it "false for blank hostname" do
@ems.update_attributes(:hostname => "", :api_version => "5.0", :uid_ems => "2E1C1E82-BD83-4E54-9271-630C6DFAD4D1")
expect(@ems.remote_console_vmrc_support_known?).not_to be_truthy
Expand Down Expand Up @@ -135,7 +130,7 @@
end

it "will restart EventCatcher when hostname changes" do
@ems.update_attributes(:hostname => "something else")
@ems.update_attributes(:hostname => "something-else")
assert_event_catcher_restart_queued
end

Expand Down

0 comments on commit 621a19f

Please sign in to comment.