Bug fix in SegmentCreationJob and SegmentCreationMapper (apache#3844)

Set job jar in SegmentCreationJob Add a missing break for switch in SegmentCreationMapper
agrawaldevesh · Feb 15, 2019 · 093f917 · 093f917
1 parent 729ba77
commit 093f917
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java b/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java
@@ -139,6 +139,8 @@ public void run()
 
     // Set up the job
     Job job = Job.getInstance(_conf);
+    job.setJarByClass(getClass());
+    job.setJobName(getClass().getName());
 
     Configuration jobConf = job.getConfiguration();
     String hadoopTokenFileLocation = System.getenv("HADOOP_TOKEN_FILE_LOCATION");

diff --git a/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java b/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java
@@ -123,6 +123,7 @@ public void setup(Context context)
             new NormalizedDateSegmentNameGenerator(_rawTableName, _jobConf.get(JobConfigConstants.SEGMENT_NAME_PREFIX),
                 _jobConf.get(JobConfigConstants.EXCLUDE_SEQUENCE_ID), validationConfig.getSegmentPushType(),
                 validationConfig.getSegmentPushFrequency(), validationConfig.getTimeType(), timeFormat);
+        break;
       default:
         throw new UnsupportedOperationException("Unsupported segment name generator type: " + segmentNameGeneratorType);
     }