-
Notifications
You must be signed in to change notification settings - Fork 1
Search #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search #517
Conversation
Everything except for firebase-tools. v11.30.0 totally breaks the function in this project so I'm waiting for a newer version to upgrade.
So that we can be like the cool kids. 👓
Not wired up to anything yet
Includes: - local caching of selected layers between sessions
I'll just have to do it manually for now. It's not a huge deal since we check for new configs on load. The issue is that the admin sdk can't authenticate with workload identity federation yet. Ref: firebase/firebase-admin-node#1377
Visit the preview URL for this PR (updated for commit 46c8a73): |
@steveoh This is ready for a look. You can see the storybook here: https://ut-dts-agrc-deq-enviro-dev--feat-search-8df6p7zg.web.app/storybook/ @nathankota You might be interested in searching a few layers and seeing the new progress indicators. I don't believe that we'll have an upper limit on the number of features returned in this new paradigm. All queries are made from the client (in parallel) directly to feature services. https://ut-dts-agrc-deq-enviro-dev--feat-search-8df6p7zg.web.app/ |
Also reorganize other non-app code. The v2 deploy was trying to do a vite build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me too. I like how it shows the results metadata above the buttons. A bit of contrast in the background could be helpful, but the line between the metadata and the buttons works okay too. I also like idea of removing a button ( |
Very basic search with unstyled results.
Looking for feedback on the search machine and new utah design system components Button & Spinner.
Try searching the "Ground Water Protection Zones" layer to see what the error state looks like in the progress component.