Skip to content

Search #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 16, 2023
Merged

Search #517

merged 23 commits into from
May 16, 2023

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented May 10, 2023

Very basic search with unstyled results.

Looking for feedback on the search machine and new utah design system components Button & Spinner.

Try searching the "Ground Water Protection Zones" layer to see what the error state looks like in the progress component.

stdavis added 6 commits May 12, 2023 09:28
Includes:
- local caching of selected layers between sessions
I'll just have to do it manually for now. It's not a huge deal since we check for new configs on load.

The issue is that the admin sdk can't authenticate with workload identity federation yet. Ref: firebase/firebase-admin-node#1377
@stdavis stdavis temporarily deployed to dev May 12, 2023 18:02 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented May 12, 2023

Visit the preview URL for this PR (updated for commit 46c8a73):
Firebase Preview: https://ut-dts-agrc-deq-enviro-dev--feat-search-8df6p7zg.web.app
(expires "2023-05-30T19:59:42.960213067Z" )

@stdavis stdavis temporarily deployed to dev May 12, 2023 18:29 — with GitHub Actions Inactive
@stdavis stdavis marked this pull request as ready for review May 12, 2023 18:33
@stdavis
Copy link
Member Author

stdavis commented May 12, 2023

@steveoh This is ready for a look. You can see the storybook here: https://ut-dts-agrc-deq-enviro-dev--feat-search-8df6p7zg.web.app/storybook/

@nathankota You might be interested in searching a few layers and seeing the new progress indicators. I don't believe that we'll have an upper limit on the number of features returned in this new paradigm. All queries are made from the client (in parallel) directly to feature services. https://ut-dts-agrc-deq-enviro-dev--feat-search-8df6p7zg.web.app/

@stdavis stdavis temporarily deployed to dev May 12, 2023 18:48 — with GitHub Actions Inactive
stdavis added 2 commits May 12, 2023 23:57
Also reorganize other non-app code.

The v2 deploy was trying to do a vite build.
@stdavis stdavis temporarily deployed to dev May 15, 2023 15:16 — with GitHub Actions Inactive
Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. I think the results state UI could be improved by removing the search button. Clear could be renamed to like start new search or something and the metadata about the search seems like it should be separated a bit more, maybe by background color or something?

image

@stdavis stdavis temporarily deployed to dev May 15, 2023 19:34 — with GitHub Actions Inactive
@nathankota
Copy link

Looks great to me too. I like how it shows the results metadata above the buttons. A bit of contrast in the background could be helpful, but the line between the metadata and the buttons works okay too. I also like idea of removing a button (Clear), unless the possibility exists where one of the searched layers fails at first, and you might want to click Search # Layers to try again?

@stdavis stdavis temporarily deployed to dev May 16, 2023 19:56 — with GitHub Actions Inactive
@stdavis stdavis merged commit cb21109 into dev May 16, 2023
@stdavis stdavis deleted the feat/search branch May 16, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants