Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 preview error #34

Open
agriffard opened this issue Sep 9, 2024 · 1 comment · Fixed by OrchardCMS/OrchardCore#16696
Open

2.0 preview error #34

agriffard opened this issue Sep 9, 2024 · 1 comment · Fixed by OrchardCMS/OrchardCore#16696

Comments

@agriffard
Copy link
Owner

Testing 2.0 using preview packages 2.0.0-preview-18334, I got an error here :

bool stickyFooter = themeSettings?.Content?.TheBootstrapThemeSettings?.StickyFooter?.Value ?? false;

RuntimeBinderException: Cannot implicitly convert type 'System.Text.Json.Dynamic.JsonDynamicValue' to 'bool'. An explicit conversion exists (are you missing a cast?)

@sebastienros
Copy link

We should also change the views that do this kind of things. We have a type and tools to bind json to settings, let's use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants