-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.0 #16427
Release 2.0.0 #16427
Conversation
This pull request has merge conflicts. Please resolve those before requesting a review. |
Triggered functional tests successfully after merging main https://github.com/OrchardCMS/OrchardCore/actions/runs/10747067540 |
I am testing 2.0 preview on multiple modules and themes (trying to update after breaking changes, ...). One of the themes I made has an error : I guess it is because of the switch from NewtonSoft to System.Text.Json but I don't know how to fix it.
I just want to be sure people won't have the same problem after 2.0 and if so, will be able to fix it. |
@agriffard can you please share the JSON string for TheBootstrapThemeSettings? |
@agriffard Yes, when using |
"TheBootstrapThemeSettings":{"ContentItemId":"4k1qt8jph1ztxy9t381jeqh9nk","ContentItemVersionId":null,"ContentType":"TheBootstrapThemeSettings","DisplayText":null,"Latest":false,"Published":false,"ModifiedUtc":"2020-05-01T19:23:54.9903382Z","PublishedUtc":null,"CreatedUtc":null,"Owner":null,"Author":"admin","TheBootstrapThemeSettings":{"Head":{"Text":"<link type="image/x-icon" rel="shortcut icon" href="/TheBootstrapTheme/favicon.ico" />"},"Foot":{"Text":null},"Background":{"Text":"dark"},"Navigation":{"Text":"FixedTop"},"StickyFooter":{"Value":false},"Bootswatch":{"Text":null}}} |
@agriffard I release a preview with the last fix. Can you please test it out soon and let me know if you have any more issues? As you know, we are getting ready to release 2.0 today or tomorrow |
No more errors with version |
@agriffard can you run the po extractor to get the latest strings in the translations (there are new adminmenu files). Thanks |
|
Fix #16428