Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #16427

Merged
merged 29 commits into from
Sep 9, 2024
Merged

Release 2.0.0 #16427

merged 29 commits into from
Sep 9, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Jul 11, 2024

Fix #16428

@MikeAlhayek MikeAlhayek added this to the 2.0 milestone Jul 20, 2024
@MikeAlhayek MikeAlhayek mentioned this pull request Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

@sebastienros
Copy link
Member

Triggered functional tests successfully after merging main https://github.com/OrchardCMS/OrchardCore/actions/runs/10747067540

@MikeAlhayek MikeAlhayek changed the base branch from main to release/2.0 September 7, 2024 21:30
@agriffard
Copy link
Member

agriffard commented Sep 9, 2024

I am testing 2.0 preview on multiple modules and themes (trying to update after breaking changes, ...).

One of the themes I made has an error :
agriffard/TheBootstrapTheme#34

I guess it is because of the switch from NewtonSoft to System.Text.Json but I don't know how to fix it.

RuntimeBinderException: Cannot implicitly convert type 'System.Text.Json.Dynamic.JsonDynamicValue' to 'bool'. An explicit conversion exists (are you missing a cast?)

https://github.com/agriffard/TheBootstrapTheme/blob/9993e862945489e29170402aeaf6757c72b70ecc/src/TheBootstrapTheme/Views/Layout.cshtml#L10

I just want to be sure people won't have the same problem after 2.0 and if so, will be able to fix it.

@MikeAlhayek
Copy link
Member Author

@agriffard can you please share the JSON string for TheBootstrapThemeSettings?

@gvkries
Copy link
Contributor

gvkries commented Sep 9, 2024

@agriffard Yes, when using dynamics, implicit conversions are not working at the moment. You have to cast to the target type manually.

@agriffard
Copy link
Member

@agriffard can you please share the JSON string for TheBootstrapThemeSettings?

"TheBootstrapThemeSettings":{"ContentItemId":"4k1qt8jph1ztxy9t381jeqh9nk","ContentItemVersionId":null,"ContentType":"TheBootstrapThemeSettings","DisplayText":null,"Latest":false,"Published":false,"ModifiedUtc":"2020-05-01T19:23:54.9903382Z","PublishedUtc":null,"CreatedUtc":null,"Owner":null,"Author":"admin","TheBootstrapThemeSettings":{"Head":{"Text":"<link type="image/x-icon" rel="shortcut icon" href="/TheBootstrapTheme/favicon.ico" />"},"Foot":{"Text":null},"Background":{"Text":"dark"},"Navigation":{"Text":"FixedTop"},"StickyFooter":{"Value":false},"Bootswatch":{"Text":null}}}

@MikeAlhayek
Copy link
Member Author

@agriffard I release a preview with the last fix. Can you please test it out soon and let me know if you have any more issues? As you know, we are getting ready to release 2.0 today or tomorrow

@agriffard
Copy link
Member

@agriffard I release a preview with the last fix. Can you please test it out soon and let me know if you have any more issues? As you know, we are getting ready to release 2.0 today or tomorrow

No more errors with version 2.0.0-preview-18337

@sebastienros
Copy link
Member

@agriffard can you run the po extractor to get the latest strings in the translations (there are new adminmenu files). Thanks

@agriffard
Copy link
Member

@agriffard can you run the po extractor to get the latest strings in the translations (there are new adminmenu files). Thanks

Done: OrchardCMS/OrchardCore.Translations@851324d

@MikeAlhayek MikeAlhayek changed the base branch from release/2.0 to main September 9, 2024 17:41
@MikeAlhayek MikeAlhayek merged commit 8e090d3 into main Sep 9, 2024
8 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/release2.0.0-docs branch September 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v2.0.0
5 participants