Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgagroal-cli reload does not take into account log_rotation settings #234

Closed
fluca1978 opened this issue May 12, 2022 · 0 comments
Closed

pgagroal-cli reload does not take into account log_rotation settings #234

fluca1978 opened this issue May 12, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@fluca1978
Copy link
Collaborator

When issuing a pgagroal-cli reload seting for log_rotation_size and similar are not transfer by transfer_configuration.
@fluca1978 fluca1978 added the bug Something isn't working label May 12, 2022
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue May 12, 2022
@fluca1978
[agroal#234] pgagroal-cli reload transfer also log_rotation settings
803ed84 
When issuing a `pgagroal-cli reload` all `log_rotation` related
settings such as `log_rotation_age` and `log_rotation_size` must be
cloned into the reloaded configuration.

This also clone the `log_line_prefix` string to the new "reloaded"
configuration.

Close agroal#234
@fluca1978 fluca1978 mentioned this issue May 12, 2022
Closed
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue May 17, 2022
@fluca1978
[agroal#234] pgagroal-cli reload transfer also log_rotation settings
c433f3c 
When issuing a `pgagroal-cli reload` all `log_rotation` related
settings such as `log_rotation_age` and `log_rotation_size` must be
cloned into the reloaded configuration.

This also clone the `log_line_prefix` string to the new "reloaded"
configuration.

Moreover, if any of the main log settings (`log_path`,
`log_rotation_xxx` or `log_mode`) are changed, the logging system is
restarted without the need to ask the user to restart the whole pooler.

Close agroal#234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#234] pgagroal-cli reload transfer also log_rotation settings fluca1978/pgagroal
1 participant
@fluca1978