Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor configuration age parsing to provide support for other configuration options #257

Closed
fluca1978 opened this issue Jun 3, 2022 · 0 comments · Fixed by #258
Closed

Refactor configuration age parsing to provide support for other configuration options #257

fluca1978 opened this issue Jun 3, 2022 · 0 comments · Fixed by #258
Labels
feature New feature

Comments

@fluca1978
Copy link
Collaborator

Related to the work in #256 : the as_log_rotation_age() function parses a string like 2h to extract the corresponding number of seconds.
It is required to extract an utility function to parse the above string independently from the logging related stuff, so that it can be used for other configuration parameters that will be introduced.
So far, this is mandatory to introduce the metrics_cache parameter for #219 and #256.
@fluca1978 fluca1978 added the feature New feature label Jun 3, 2022
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Jun 3, 2022
@fluca1978
[agroal#257] Refactoring of the configuration age and size parsing.
dde2458 
This commit introduces two utility functions:
- `as_seconds()` that parses an "age" string (e.g., "2d") and returns the
   extracted value as seconds;
- `as_bytes()` parses a "size" string (e.g., "2m") and returns the
  number of bytes the string represents.

Such utility functions can be used as backbone for introducing new configuration
parameters, so far they are used as delegates
for `as_log_rotation_age()` and `as_log_rotation_size()`.

Also, converts the `log_rotation_age` and `log_rotation_size` configuration
parameters to `unisgend int`: it does not make any sense to have a negative
rotation value.

In the case a configuration parameter for an age or a size is expressed
as a negative value, a warn about the "unknown" configuration value
is issued.

Documentation updated.

Close agroal#257
@fluca1978 fluca1978 mentioned this issue Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#257] Refactoring of the configuration age and size parsing. fluca1978/pgagroal
1 participant
@fluca1978