Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match HTML p tags in home page #265

Closed
fluca1978 opened this issue Jun 13, 2022 · 1 comment · Fixed by #266
Closed

Match HTML p tags in home page #265

fluca1978 opened this issue Jun 13, 2022 · 1 comment · Fixed by #266

Comments

@fluca1978
Copy link
Collaborator

The prometheus.c home_page functuion outputs a set of information that have a structure like:

<h2>tite</h2>
bla bla
<p>

while it should be something like:

'''

title

bla bla

```

so that p tags are always matched. This does not cause at the moment any problem with browsers, but makes the HTML code cleaner and more correct.
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Jun 13, 2022
@fluca1978
[agroal#265] Match HTML p tags in home page
7386085 
The `home_page()` function provides an HTML page with the description
of all the metrics exported to Prometheus.
The HTML code was missing the `<p>` and `</p>` pairs, only one `<p>`
was present at the end of each section.
This commit fixes the problem and indents the code of one space within
each paragraph.

Close agroal#265
@fluca1978 fluca1978 mentioned this issue Jun 13, 2022
Merged
@jesperpedersen
Copy link
Collaborator

The HTML should pass the XHTML check on validator.w3.org

@fluca1978 fluca1978 mentioned this issue Jun 14, 2022
Closed
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Jun 14, 2022
@fluca1978
[agroal#265][agroal#267] HTML validation and cleanup
12da246 
This commit refactors the HTML produced by `home_page()` function that
describes the set of metrics exported to Prometheus.

The produced HTML now passes the XHTML validation at
<https://validator.w3.org>, using CSS and other tags to make the
document well formed.

It also fixes the problem of the `p` pairs: before this there were
only opening paragraphs at the end of each section.

Close agroal#265
Close agroal#267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#265] Match HTML p tags in home page fluca1978/pgagroal
2 participants
@jesperpedersen @fluca1978