Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#163] Add internal network traffic metrics #164

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

An-DJ
Copy link
Contributor

@An-DJ An-DJ commented Aug 6, 2021

Add new network traffic panels in the dashboard and the following metrics:

  • pgagroal_network_sent
  • pgagroal_network_received

Modify the spelling of some words in the dashboard.

@jesperpedersen
Copy link
Collaborator

Why not _add(ssize_t) ?

@An-DJ
Copy link
Contributor Author

An-DJ commented Aug 7, 2021

Why not _add(ssize_t) ?

Yeah, it's a little bit more concise. I have modified the code just now.

@jesperpedersen
Copy link
Collaborator

Yeah, that looks better - maybe name them network_sent and network_receive in the function names as well

@jesperpedersen
Copy link
Collaborator

jesperpedersen commented Aug 7, 2021

Also name the parameter, as

/**
 * Increase network_sent
 * @param s The size
 * /
void pgagroal_prometheus_network_sent(ssize_t s);

@An-DJ
Copy link
Contributor Author

An-DJ commented Aug 7, 2021

Also name the parameter, as

/**
 * Increase network_sent
 * @param s The size
 * /
void pgagroal_prometheus_network_sent(ssize_t s);

Done.

@jesperpedersen
Copy link
Collaborator

Better do it in prometheus.c and the Grafana file as well

Add the following metrics:
* pgagroal_network_sent
* pgagroal_network_received
@An-DJ
Copy link
Contributor Author

An-DJ commented Aug 7, 2021

Better do it in prometheus.c and the Grafana file as well

Done.

@jesperpedersen jesperpedersen merged commit 816d412 into agroal:master Aug 7, 2021
@jesperpedersen
Copy link
Collaborator

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants