[#316] Use err(3)
#317
Closed
[#316] Use err(3)
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever in the code there is a `printf` + `exit` or similar piece of code, use `err(3)` functions instead. This brings coherency, removes the need for the extra new line, the program name and provides automatic expansion of errors when needed. This also changes the `create_pidfile` sttic function so that it terminates the current program (main) if the pid file cannot be created. To emphasize this, the function has been renamed to `create_pidfile_or_exit`. Also the `remove_pidfile` changed to emit a warning if the pid file cannot be removed Close agroal#316
|
Merged. Thanks for the contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever in the code there is a
printf+exitor similar piece ofcode, use
err(3)functions instead.This brings coherency, removes the need for the extra new line, the
program name and provides automatic expansion of errors when needed.
This also changes the
create_pidfilestatic function so that itterminates the current program (main) if the pid file cannot be
created. To emphasize this, the function has been renamed to
create_pidfile_or_exit. Also theremove_pidfilechanged to emit awarning if the pid file cannot be removed
Close #316