[#339] Count how many settings remain unchanged in configuration reload. #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n reload. The internal function `transfer_configuration` now returns a negative value in the case of unchanged settings: such value counts the number of parameters that has remained untouched, for example because they require a restart. The idea is that there are parameter that cannot be changed on the fly and that do not prevent the configuration to be swapped, but it could be interesting to take the count of unchanged configuration settings. Close agroal#339
|
I'm slowly changing m,y mind about this: what about leaving |
|
Rebased, and merged. Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal function
transfer_configurationnow returns a negative value in the case of unchanged settings: such value counts the number of parameters that has remained untouched, for example because they require a restart.The idea is that there are parameter that cannot be changed on the fly and that do not prevent the configuration to be swapped, but it could be interesting to take the count of unchanged configuration settings.
Close #339