-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept abstract namespace paths for unix domain sockets #782
Merged
agronholm
merged 3 commits into
agronholm:master
from
tapetersen:accept-abstract-unix-sockets
Sep 5, 2024
Merged
Accept abstract namespace paths for unix domain sockets #782
agronholm
merged 3 commits into
agronholm:master
from
tapetersen:accept-abstract-unix-sockets
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapetersen
force-pushed
the
accept-abstract-unix-sockets
branch
from
September 4, 2024 12:25
d32fcba
to
d85a6a1
Compare
agronholm
requested changes
Sep 4, 2024
tapetersen
force-pushed
the
accept-abstract-unix-sockets
branch
4 times, most recently
from
September 5, 2024 09:11
bd6f768
to
d5a98c9
Compare
@agronholm I'm not sure about what if any updates to the documentation should be done apart from the changelog entry. |
Accept paths starting with a null byte in create_unix_listener and connect_unix_socket to allow creating abstract unix sockets. Fixes agronholm#781
tapetersen
force-pushed
the
accept-abstract-unix-sockets
branch
from
September 5, 2024 09:44
d5a98c9
to
f76b139
Compare
agronholm
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finishing touches.
agronholm
reviewed
Sep 5, 2024
agronholm
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
tapetersen
force-pushed
the
accept-abstract-unix-sockets
branch
from
September 5, 2024 15:17
dae730b
to
c9e282c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Accept paths starting with a null byte in create_unix_listener and connect_unix_socket to allow creating abstract unix sockets. Fixes #781
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/
) added which would fail without your patchdocs/
, in case of behavior changes or newfeatures)
docs/versionhistory.rst
).Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**
as the version.If, say, your patch fixes issue #123, the entry should look like this:
* Fix big bad boo-boo in task groups (#123 <https://github.com/agronholm/anyio/issues/123>_; PR by @yourgithubaccount)
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.