Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept abstract namespace paths for unix domain sockets #782

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

tapetersen
Copy link
Contributor

@tapetersen tapetersen commented Sep 4, 2024

Changes

Accept paths starting with a null byte in create_unix_listener and connect_unix_socket to allow creating abstract unix sockets. Fixes #781

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

* Fix big bad boo-boo in task groups (#123 <https://github.com/agronholm/anyio/issues/123>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

tests/test_sockets.py Outdated Show resolved Hide resolved
tests/test_sockets.py Outdated Show resolved Hide resolved
@tapetersen tapetersen force-pushed the accept-abstract-unix-sockets branch 4 times, most recently from bd6f768 to d5a98c9 Compare September 5, 2024 09:11
@tapetersen
Copy link
Contributor Author

@agronholm I'm not sure about what if any updates to the documentation should be done apart from the changelog entry.

Accept paths starting with a null byte in create_unix_listener and
connect_unix_socket to allow creating abstract unix sockets. Fixes agronholm#781
Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finishing touches.

docs/versionhistory.rst Outdated Show resolved Hide resolved
src/anyio/_core/_sockets.py Outdated Show resolved Hide resolved
docs/versionhistory.rst Outdated Show resolved Hide resolved
Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agronholm agronholm merged commit 38890e6 into agronholm:master Sep 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_unix_listener doesn't accept abstract namespace sockets
2 participants