-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #982
Fix tests #982
Conversation
After I opened the PR, I thought about the possible "fix". Instead of removing test, I could just skip testing for newer versions of Uwsgi. I didn't think about this before, but if anyone prefers I can try to do it later. |
Perhaps you could just disable threads explicitly? The scheduler should be allowed to run if uwsgi has threads enabled, and fail if it doesn't, regardless of version. |
I had looked for an option in uwsgi to disable threads. And I believe there is no such option or I did not find it |
|
In that case, the |
Actually, in new versions of uwsgi I don't know yet when the value of has_threads(
|
Sorry, I ended up closing the PR by accident 🤦♂️ |
Do you mean, skip this specific test for new versions of uwsgi? |
No, I mean install an old version of uwsgi that still disables threading by default. |
Done! |
Thanks! |
Removed failed test that checked if the Scheduler was running on uwsgi with threads disabled. Now in new versions of uwsgi threads are enabled by default.
Reference to uwsgi change: unbit/uwsgi@896ee57