-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch format-exception-only too #8
Conversation
Did the test suite pass for you locally? |
1086e58
to
051d30e
Compare
b5917e1
to
0da48ab
Compare
for more information, see https://pre-commit.ci
You should pull in the pre-commit changes (or install the pre-commit hook locally) instead of force pushing the changes. |
Sorry for the churn - turns out that when running pytest directly I needed to do a full non-editable install before testing each change. Pre-commit is also now installed and working on my new laptop 👍 |
Shouldn't the 3.11 tests pass already btw? It runs on 3.11a7 now. |
Hm, it does pass for me locally and I'm using the git version beyond a7 so I guess it's all okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple code style changes, otherwise looks fine. I'll go ahead and commit those style changes.
Thanks! |
Released v1.0.0rc5. |
Thanks @agronholm! While I'm hoping this is the last time I need to come back here, that's not because I don't appreciate working with you 😀 The |
Fixes #7, ensuring that e.g. Pytest's traceback formatting (which uses
format_exception_only()
) will also show notes.