Add properties for client.publish() #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12432654411Details
💛 - Coveralls |
|
What is your end goal with this? I'm not sure we should allow setting arbitrary MQTT-level properties. User properties, on the other hand, are fair game. |
|
My main case now is using MESSAGE_EXPIRY_INTERVAL. I need to avoid case if clients go online from offline and gets message too late, unexpected for me. Also CORRELATION_DATA and RESPONSE_TOPIC would be useful for request/response pattern |
|
I'll think about how to best provide these features. Meanwhile, this needs either a new test or an amended existing test to cover this new feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.