Backport thread_name_prefix from upstream
#64
Merged
+47
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional `thread_name_prefix` argument to constructor of ThreadPoolExecutor. Resolves agronholm#63
agronholm
reviewed
Aug 4, 2017
concurrent/futures/thread.py
Outdated
| @@ -109,6 +110,7 @@ def __init__(self, max_workers=None): | |||
| self._threads = set() | |||
| self._shutdown = False | |||
| self._shutdown_lock = threading.Lock() | |||
| self._thread_name_prefix = thread_name_prefix | |||
There was a problem hiding this comment.
Your PR seems incomplete. This part of the code differs from upstream: https://github.com/python/cpython/blob/master/Lib/concurrent/futures/thread.py#L109-L110
There was a problem hiding this comment.
Ah, I missed that. It seems to be from a more recent fix (python/cpython#2315) which should nevertheless be included here. I'll apply the second patch in another commit on this branch.
|
The tests fail. Please fix the code. I will merge it then. |
sseg
force-pushed
the
backport_issue_27664
branch
2 times, most recently
from
c909643 to
d16bb53
Compare
|
Thanks! |
li-dan
pushed a commit
to li-dan/typeshed
that referenced
this pull request
Jun 18, 2018
The thread_name_prefix argument of ThreadPoolExecutor.__init__ was added to the Python 2 backport in agronholm/pythonfutures#64.
JelleZijlstra
pushed a commit
to python/typeshed
that referenced
this pull request
Jun 18, 2018
The thread_name_prefix argument of ThreadPoolExecutor.__init__ was added to the Python 2 backport in agronholm/pythonfutures#64.
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
The thread_name_prefix argument of ThreadPoolExecutor.__init__ was added to the Python 2 backport in agronholm/pythonfutures#64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional
thread_name_prefixargument to constructor of ThreadPoolExecutor.Resolves #63
cc @agronholm @gpshead