-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SQLAlchemy 2.0, continued #275
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
* Remove some formatting changes * Remove pytest importlib config option * Add mention of support for SQLAlchemy 2 to README
Thanks, I'll check this out later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code is good enough for merging. I'll do some tinkering on it later.
Aside from the suggestions I've added, I will still need an added changelog entry (remember to give credit to yourself and the author of the original PR).
|
Thanks a lot! |
No problem, @rbuffat did all the actual work here. Do you plan to release this to pypi or do you want further changes before that? |
I think I will first tinker with the test suite and then release to PyPI later this week. |
What are you getting exactly? |
Hi @agronholm, sorry to keep pestering you, I know you have competing priorities. Is there anything I can do to help in getting the SQLAlchemy 2 support into a PyPi release? It would unblock a series of dependency upgrades for our project. |
I wanted to fix a couple more bugs first, but looks like I didn't have the time. I've released v3.0.0rc3 now to unblock your upgrades. |
Hello:
I get an error like this:
After which there is a python package actually called UNKNOWN, which I can uninstall with |
Have you tried installing from the PyPI? |
Thanks, that works! And it gave in a blink some nice looking python code! Genius! |
Continued from #249, see discussion there.