enable finer selection on tables #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow to express the tables to process via regexp both to explicitly keep tables or to explicitly exclude tables
for more information, see https://pre-commit.ci
|
This lacks:
When these have been added, I will review this PR. |
|
I do this with pleasure if you think the feature is worth. Is it?
And is there any test already that tests the --table argument? I wanted to
add a test but could not find one to extend/adapt
…On Tue, 17 Oct 2023, 15:39 Alex Grönholm, ***@***.***> wrote:
This lacks:
- tests
- documentation updates
- an added changelog entry
When these have been added, I will review this PR.
—
Reply to this email directly, view it on GitHub
<#296 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ6S5XWBSYGT4TGPDUBUO3X72C7JAVCNFSM6AAAAAA6DQZ5ZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGQZTSOJYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
There are no tests for it that I can see. It would be nice to test both ways. Do you mind adding those too? |
|
If you could provide (even in comment in this thread) a skeleton of test
for the current --table feature, it would be very useful. Designing a test
with a fake database + fake CLI call with arguments is too challenging for
me. However, once I have a running test, then I will be able to duplicate
it and enrich it to cover the 'ew feature.
…On Tue, 24 Oct 2023, 00:05 Alex Grönholm, ***@***.***> wrote:
There are no tests for it that I can see. It would be nice to test both
ways. Do you mind adding those too?
—
Reply to this email directly, view it on GitHub
<#296 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ6S5XC45XSGJBGI4YAASDYA3S4NAVCNFSM6AAAAAA6DQZ5ZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGA4TKOJTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to express the tables to process via regexp both to explicitly keep tables or to explicitly exclude tables