Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic is that, if a table has no primary key, it doesn't use the declarative class generator. However, sqlite has the hidden
rowid
column which acts as a primary key. For this reason, I want to generate a dataclass and then addrowid
as the primary key so that I get all the nice type safety of a dataclass. There are probably also other use cases for ignoring this rule.Thus, this PR adds a new option called
force_class
that will generate a dataclass even if there is no obvious primary key.