Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made @typechecked a no-op in optimized mode #350

Merged
merged 4 commits into from
May 1, 2023
Merged

Made @typechecked a no-op in optimized mode #350

merged 4 commits into from
May 1, 2023
+59 −0

Conversation

agronholm
Copy link
Owner

Closes #348.

@agronholm agronholm force-pushed the typechecked-optimized branch from daa4790 to 7784f59 Compare April 30, 2023 15:25
@coveralls
Copy link

Coverage Status

Coverage: 96.774%. Remained the same when pulling 7ca693e on typechecked-optimized into 43d686e on master.

@agronholm agronholm mentioned this pull request Apr 30, 2023
Closed
@agronholm
Copy link
Owner Author

I'd still like @zackmccord to give a thumbs up before I merge and release.

@zackmccord
Copy link

Thank you for this. Looks good to me!

@agronholm agronholm merged commit 8923b7b into master May 1, 2023
@agronholm agronholm deleted the typechecked-optimized branch May 1, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UriyaHarpeness UriyaHarpeness UriyaHarpeness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@typechecked decorator no longer respects sys.flags.optimize
4 participants
@agronholm @coveralls @zackmccord @UriyaHarpeness