-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Python 3.14 and PEP 649 #492
Draft
JelleZijlstra
wants to merge
4
commits into
agronholm:master
Choose a base branch
from
JelleZijlstra:fix314
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran the typeguard test suite on the current CPython main branch to look for possible breakage from PEP 649 and 749, which makes large changes to how annotations work. I found three problems: - DeprecationWarnings from uses of ForwardRef._evaluate, which we're deprecating. Made a change to use the new public API for ForwardRef.evaluate instead. - A test failure that showed "annotationlib" as the module name for a forward ref. I made it so that it doesn't use __module__ for ForwardRef objects. - One remaining test failure that I haven't tracked down: tests/test_instrumentation.py::test_typevar_forwardref[importhook] It's apparently due to caching (it doesn't fail if I run only that one test), but I haven't tracked down the exact cause. Since the APIs in Python 3.14 may still change, I'll make this a draft PR for now.
2 tasks
Thanks for working on this! I just tested this branch with Python 3.14.0a1, and it looks like some further adjustments will be required:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the typeguard test suite on the current CPython main branch to
look for possible breakage from PEP 649 and 749, which makes large
changes to how annotations work.
I found three problems:
deprecating. Made a change to use the new public API for ForwardRef.evaluate
instead.
ref. I made it so that it doesn't use module for ForwardRef objects.
tests/test_instrumentation.py::test_typevar_forwardref[importhook]
It's apparently due to caching (it doesn't fail if I run only that one test),
but I haven't tracked down the exact cause.
I also added some new tests relying on 3.14-only behavior (unquoted annotations containing forward references). Those mostly worked fine, but I had to make another tweak to how functions are wrapped.
Since the APIs in Python 3.14 may still change, I'll make this a draft
PR for now.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/
) added which would fail without your patchdocs/
, in case of behavior changes or newfeatures)
docs/versionhistory.rst
).