Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error for localized boolean values #2

Closed
ahaasler opened this issue Aug 20, 2015 · 1 comment
Closed

Error for localized boolean values #2

ahaasler opened this issue Aug 20, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@ahaasler
Copy link
Owner

If there's a localized configuration variable with a value of false the default one is returned.

@ahaasler ahaasler added the bug label Aug 20, 2015
@ahaasler ahaasler self-assigned this Aug 20, 2015
@ahaasler ahaasler added this to the 0.1.4 milestone Aug 20, 2015
@ahaasler
Copy link
Owner Author

This line must be the cause:

return retrieveItem(locals.data['config_' + lang], value) || retrieveItem(config, value);

It should be checked if the retrieved value is undefined instead of doing that lazy || 😅.

ahaasler added a commit that referenced this issue Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant