-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement caching mechanism in the library #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added CachePolicy class to manage cache settings and TTLs - Added CacheStore class for in-memory caching Signed-off-by: Sonu Saha <ahasunos@gmail.com>
- Added tests for CacheStore to verify data caching, TTL expiration, and data deletion. Signed-off-by: Sonu Saha <ahasunos@gmail.com>
- Added tests for CachePolicy to ensure correct caching behavior and TTL handling. - Updated specs to verify cache behavior with and without forced refresh. Signed-off-by: Sonu Saha <ahasunos@gmail.com>
Signed-off-by: Sonu Saha <ahasunos@gmail.com>
- Updated FaradayClient to apply caching based on CachePolicy settings. - Configured Faraday to use HTTP caching middleware conditionally. Signed-off-by: Sonu Saha <ahasunos@gmail.com>
- Added tests for FaradayClient to ensure it handles caching and connection errors properly. - Added tests for APIManager to verify correct data fetching and cache handling.- Updated specs to cover endpoint validation and cache refresh scenarios. Signed-off-by: Sonu Saha <ahasunos@gmail.com>
Signed-off-by: Sonu Saha <ahasunos@gmail.com>
Signed-off-by: Sonu Saha <ahasunos@gmail.com>
Signed-off-by: Sonu Saha <ahasunos@gmail.com>
Signed-off-by: Sonu Saha <ahasunos@gmail.com>
Signed-off-by: Sonu Saha <ahasunos@gmail.com>
Signed-off-by: Sonu Saha <ahasunos@gmail.com>
Signed-off-by: Sonu Saha <ahasunos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a caching mechanism to the library.
The new caching feature is designed to improve the performance and efficiency of API calls by reducing redundant requests and utilizing cached responses where appropriate.
Key Changes:
CachePolicy
class to manage caching behavior, including setting global TTLs, custom TTLs for specific endpoints, and controlling cache usage on a per-endpoint basis.fetch
method to handle caching logic, allowing users to retrieve data from the cache or fetch fresh data as needed.FaradayClient
class to integrate with the new caching policy, applying caching logic based on theCachePolicy
settings.Related Issue
Fixes #32
Type of change
Checklist: