Windows Implementation for the app-icon library
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(deps): update rust crate cocoa to 0.25.0
feat/app icon
rename app_icon::get_app_icon to app_icon::get_icon
chore: add mock implementation for other windows & linux
chore: docs
chore: docs
chore(deps): update rust crate core-foundation to 0.9.4
feat: monitor utils library
feat: add visible frame
feat: implement getter methods
refacor: rename identifier
feat: update docs
chore(deps): update rust crate serde to v1.0.202
fix(deps): update tauri monorepo
chore(deps): update dependency vite to v5.2.11
chore(deps): update rust crate tauri to v1.6.7
feat: add menubar lib
chore(docs): update
chore(docs): update
chore(deps): update rust crate serde to v1.0.203
ahkohd
approved these changes
May 30, 2024
There was a problem hiding this comment.
@Lilit0x, thanks for this PR. I have some requests before you merge:
- Please update the README.md and [x] for Windows.
- Could you share a screenshot showing the code in action?
- If you don't sign your commits, I won't be able to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a windows implementation for the
app-iconlib.