Skip to content

Commit

Permalink
Fixing Managed Identity Issue allowing connection between App Service…
Browse files Browse the repository at this point in the history
… and Azure Purview (feathr-ai#579)

* Adding EventHub creation to the deployment script

* Upgrading API versions and fixing the if clause of KV property creation for EH

* Removing the need to ask for Principal Id from user and creating it in the template. Also removing bacpac file url parameter, and copying it to user's storage account as part of the template. This simplifies the flow for user

* Making template more organized and updated documentaton

* Addressing Blair's feedback to change registry image and app variable names

* Fix for redirect URI, the callback one stopped working

* Removing duplicate deployment text and adding reference to main guide so changes could be done only at single place

* Adding parameters to support RBAC and passing them to app settings

* Separating CLI and ARM documentation, adding bacpac import for RBAC, more bug fixes and doc change

* Adding managed identity to webapp, instructions for Purview data curator role, consolidating bacpac into one

* Fixing broken document link

* Addressing PR feedback to remove commented code

* Fixing broken links

* Moving notebook under samples folder, minor updates to prod_reco advance notebook to get it working, and an extra permisison is required in notebook to submit job on Synapse

* Adding instructions for steps to verify deployment was successful and run notebook samples

* Removing feathr install from forked repo

* Updating image

* Fixing links, to get pytest check-link work. They would have worked but the absolute URL won't resolve until PR is merged.

* Adding UI URL format

* Fixing link that is being identified as broken

* Adding workflow for docker publish

* Update docker-publish.yml

* Update docker-publish.yml

* Rename FeathrRegistry.Dockerfile to Dockerfile

* Update docker-publish.yml

* Update docker-publish.yml

* updating cron time

* updating cron time

* updating cron time

* updating cron time

* adding tag trigger

* Updating cron time to check if its working

* Adding trigger for release branch

* Changing schedule for daily run

* Changing schedule for daily run

* Changing schedule for nightly run

* Renaming the file back

* Adding more comments and pointing to dockerfile with different name than default

* Removing dockefile

* Removing reference to a specific commit number for GH docker actions

* Add or update the App Service deployment workflow configuration from Azure Portal.

* Update main_rjrijaiwebapp.yml

* Adding Managed Identity CLient ID to App Settings of App Service so it can communicate with Azure Purview

* Removing workflow files from this branch
  • Loading branch information
jainr authored and ahlag committed Aug 26, 2022
1 parent 37d6ee1 commit 6eb99c7
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions docs/how-to-guides/azure_resource_provision.json
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,10 @@
{
"name": "PURVIEW_NAME",
"value": "[if(equals(parameters('registryBackend'),'Azure-Purview'),variables('purviewName'),json('null'))]"
},
{
"name": "AZURE_CLIENT_ID",
"value": "[reference(resourceId('Microsoft.ManagedIdentity/userAssignedIdentities', variables('identityName')), '2018-11-30','Full').properties.clientId]"
}
]
}
Expand Down

0 comments on commit 6eb99c7

Please sign in to comment.