Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 NEW: Bar chart #91

Merged
merged 5 commits into from
Apr 23, 2020
Merged

📦 NEW: Bar chart #91

merged 5 commits into from
Apr 23, 2020

Conversation

ChrisWeldon
Copy link
Contributor

Added stacked bar charts for Cases + Deaths + Recovered.
Incorporates sorting tags and options for displaying.

Examples:
corona --bar
corona --bar -s critical
corona --bar --limit 8 (default limit is 12)

To Do:
- add different feature comparisons such as daily or critical comparison
- fix center bar labels.

Copy link
Owner

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✔︎

@ChrisWeldon there were a lot of small issues with the PR that I fixed myself, I encourage you to read what I did about 5 mins from now as I commit those changes and release this new major version.

Thanks a lot for this bar chart feature looks pretty fantastic, to be honest.

I changed the colors, sort labels, and labels + bar foreground colors. Also made sure that sorted data only has that data which we are sorting for, and that bars have colors. :)

@ahmadawais ahmadawais changed the title Bar chart 📦 NEW: Bar chart Apr 23, 2020
@ahmadawais ahmadawais merged commit 8de7d68 into ahmadawais:master Apr 23, 2020
@ahmadawais
Copy link
Owner

@ahmadawais
Copy link
Owner

@ChrisWeldon bar charts per country would be fun. :)

@ChrisWeldon
Copy link
Contributor Author

Great! Thank you for being so welcoming @ahmadawais. On my next pull request, I will try to be a little more vigilant on the smaller issues. I'll see if I can add some neet features to the bar charts and maybe take on some other issues in the feed.

@ahmadawais
Copy link
Owner

Great. Also run npm run format before commit. We should add that as a husky git tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants