Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events Calendar Page(Months Page) is getting blank when when 'Minify' option is enable under performance tab #4080

Closed
santosh8793 opened this issue Jan 17, 2020 · 3 comments

Comments

@santosh8793
Copy link
Contributor

Below is the url where the issue was occurring when minify option is enabled which is fixed by modify the code from
$process = preg_replace(array ('/>[^\S ]+' . $mod, '/[^\S ]+<' . $mod, '/\s+/' ), array('> ', ' <', ' '), $process);
to
$process = preg_replace(array ('/>[^\S ]+' . $mod, '/[^\S ]+<' . $mod ), array('> ', ' <' ), $process);
https://setx.events/events/month/?amp

This issue is not getting recreated in localhost.

Reff: https://trello.com/c/3yc3gc0E/1370-event-month-calendar-page-is-blank-in-amp-version

@ahmedkaludi ahmedkaludi added this to the Stabilize milestone Jan 17, 2020
@Zabi09 Zabi09 assigned Zabi09 and unassigned Zabi09 Jan 18, 2020
Zabi09 added a commit that referenced this issue Jan 18, 2020
@MohammedKaludi
Copy link
Collaborator

Are you sure this is the correct fix?

I think that there is some issues in the code.

@MohammedKaludi MohammedKaludi assigned WasimM3 and unassigned Zabi09 Jan 26, 2020
WasimM3 added a commit that referenced this issue Jan 28, 2020
@MohammedKaludi
Copy link
Collaborator

MohammedKaludi commented Feb 4, 2020

Ready to merge.

@MohammedKaludi
Copy link
Collaborator

Pushed in 1.0.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants