i have some questions about performance

[aijingsun6]

1. in log_manager.erl function notify_logger use gen_event:sync_notify(...) it was blocked util message ahead was handled,why not use method gen_event:notify(...)

2. when so many messages send to defalut_logger ,the memory was cost a lot,why not use another form of message queue,like ets cache?

[ahmednawras]

Hi Alking, Please find my comments below

On Mon, Dec 3, 2018 at 3:11 PM alking ***@***.***> wrote: 1. in log_manager.erl function notify_logger use gen_event:sync_notify(...) it was blocked util message ahead was handled,why not use method gen_event:notify(...) Some users would need to ensure that the log is received. Perhaps this can

be done to be configurable per logger.

1. 2. when so many messages send to defalut_logger ,the memory was cost a lot,why not use another form of message queue,like ets cache? this complicates the design of log4erl and doesn't add any value;

regardless of message queue (erlang built-in message queue or another queue system), memory consumption will still be there. I don't think there's value here. A better approach I can see is to use syslog or distributed logging; which should also fix #1 above.

1. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADlt53BzKGljh4y5trSI-OLudkPiBRgks5u1Qb2gaJpZM4Y-XWK> .

Ahmed

[aijingsun6]

Hi,ahmednawras

for problem 1, I understand your design now, but on my experience,at most situation,log system is a base component, i don't use the result of logger and don't care about the result.

for problem 2, in my production application, when use etop profiling my application ,the largest message queue size of processes is default_logger i think it is a problem and bottleneck.
when a gen_event process called default_logger with many event handler , the message consumption is very slow.

thanks for your answer.

alking