Fix "Avoid mutable default arguments" issue #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnitz
pushed a commit
that referenced
this pull request
May 22, 2017
* main function of pycbc qtransform script * Fractional mismatch between neighbouring tiles function * stand-a-lone qtransform spectrogram plotting executable. * Removed q-transform directory with deltam.py and main.py stand-a-lone scripts * removed .py on end of qtransform_plotter, removed main() function in qtransform.py, added #!/usr/bin/env python to qtransform_plotter executable * cleaned up imports section of qtransform.py, removed qtransform_plotter executable from this pull request * Added qtransform function * Added additional comments, added Returns section to qtransform def, fixed unit errors * Update qtransform.py * # This is a combination of 2 commits. # This is the 1st commit message: Added qtransform function # This is the commit message #2: Added additional comments, added Returns section to qtransform def, fixed unit errors * normalized variable is now keyword argument, removed sampling variable, duration definition simplified
ahnitz
force-pushed
the
master
branch
2 times, most recently
from
1dbb691
to
3c4d5a8
Compare
ahnitz
pushed a commit
that referenced
this pull request
Aug 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request automatically fixes all occurrences of the following issue:
Issue type: Avoid mutable default arguments
Issue details: https://www.quantifiedcode.com/app/project/gh:ahnitz:pycbc?groups=code_patterns/%3A3P0qV6OB
To adjust the commit message or the actual code changes, just rebase or cherry-pick the commits.
For questions or feedback reach out to cody@quantifiedcode.com.
Legal note: We won't claim any copyrights on the code changes.
Cheers,
Cody - Your code quality bot