Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands aren't alphabetized or even consistent order #1

Closed
frankcarey opened this issue Oct 30, 2015 · 2 comments
Closed

Commands aren't alphabetized or even consistent order #1

frankcarey opened this issue Oct 30, 2015 · 2 comments

Comments

@frankcarey
Copy link
Contributor

if you run ahoy help or just ahoy multiple times, you'll notice the order of the commands changes each time. I'm guessing it's the way the .ahoy.yml file is read in (currently?).

Best solution would probably be to list them alphabetically.
@frankcarey
Copy link
Contributor Author

This is due to go's randomized iteration. Keys should be specifically sorted and then used to access the hash map. See http://nathanleclaire.com/blog/2014/04/27/a-surprising-feature-of-golang-that-colored-me-impressed/

frankcarey pushed a commit that referenced this issue Dec 7, 2015
Issue #1 - Sort (new) commands in alphabetical order.
9bfbc2d
frankcarey pushed a commit that referenced this issue Dec 7, 2015
Merge pull request #10 from devinci-code/dev-1-ordered-commands
d9eeeaa 
Issue #1 - Sort (new) commands in alphabetical order.
@frankcarey
Copy link
Contributor Author

Merged in #10 - Command are not consistently alphabetical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frankcarey