Allow <json repr="string"> for int types
#330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiantoh
requested review from
rgrinberg,
Khady,
mjambon,
zindel and
cyberhuman
as code owners
cyberhuman
reviewed
Feb 27, 2023
Comment on lines
+683
to
+722
| "json encoding int with string representation", test_encoding_int_with_string_repr; | ||
| "json encoding & decoding int with string representation", test_encoding_decoding_int_with_string_repr; |
There was a problem hiding this comment.
can we have a couple of tests encoding ints as ints?
|
Hi @mjambon, would appreciate your review on this PR. Thank you |
|
@mjambon gentle ping. I'll be happy to address any concerns you may have about this PR 🙂 |
|
@sebastiantoh sorry, I didn't realize you wanted my review specifically. I reviewed the changes, it looks good to me. Let's merge it. I was wondering what happens to the target languages (Python, ...) that don't support |
|
@sebastiantoh and thank you! |
mjambon
added a commit
to mjambon/opam-repository
that referenced
this pull request
May 12, 2023
…n-codec-runtime and atd (2.12.0) CHANGES: * atdgen: Annotate generated code with types to disambiguate OCaml classic variants (ahrefs/atd#331) * atdpy: Support the option type more correctly so that it follows ATD's convention for JSON encoding. This allows compatibility with JSON produced by other tools of the ATD suite. The Python type, however, is still a nullable (`Optional`) to make things simpler for Python programmers. This prevents distinguishing `["Some", "None"]` from `"None"` which both translate to `None` in Python. (ahrefs/atd#332) * (BREAKING) atdgen: revert default encoding of int64 values as string (ahrefs/atd#330) * atdgen: Support `<json repr="string">` for `int` values (ahrefs/atd#330) * atdpy: Treat default field values as expressions to evaluate each time they're assigned to a field. This allows the use of mutable defaults such as lists (ahrefs/atd#339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #273 and supersedes #291
<json repr="string">annotation for int typesPR checklist
CHANGES.mdis up-to-date