GitHub Action to replace Travis CI #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
added a commit
to cclauss/python-magic
that referenced
this pull request
May 16, 2024
As discussed at ahupp#317 (comment) this file is useless without a paid subscription to Travis CI. GitHub Actions is free to open source projects but Travis CI is not. * ahupp#318
Merged
ahupp
pushed a commit
that referenced
this pull request
May 16, 2024
As discussed at #317 (comment) this file is useless without a paid subscription to Travis CI. GitHub Actions is free to open source projects but Travis CI is not. * #318
|
@ahupp Your review, please. It would help to have automated tests running. |
ddelange
reviewed
May 20, 2024
| @@ -157,6 +161,8 @@ def test_descriptions(self): | |||
| finally: | |||
| del os.environ["TZ"] | |||
|
|
|||
| # TODO: Fix this failing test on Ubuntu | |||
| @pytest.mark.skipif(sys.platform == "linux", reason="'JSON data' not found") | |||
There was a problem hiding this comment.
fwiw, pytest was completely green for most linux architectures when running pytest using the cibuildwheel mechanism ref #294 (comment)
There was a problem hiding this comment.
Are you able to create a targeted fix for #321?
There was a problem hiding this comment.
there was nothing to fix, pytest was green out of the box 🤔
There was a problem hiding this comment.
maybe because im building and bundling latest libmagic from source, and github ubuntu comes with an old libmagic?
cclauss
added a commit
to cclauss/python-magic
that referenced
this pull request
May 20, 2024
As discussed at ahupp#317 (comment) this file is useless without a paid subscription to Travis CI. GitHub Actions is free to open source projects but Travis CI is not. * ahupp#318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test results: https://github.com/cclauss/python-magic/actions
The Python 3.13 release notes mention
python-magicas one of the alternatives forimghdrwhich was removed from the Standard Library so let's ensure that its tests pass on Python 3.13 beta.https://www.python.org/downloads/release/python-3130b1/
May raise
ModuleNotFoundError: No module named 'imghdr'because Python 3.13 removes it from the Standard Library.https://docs.python.org/3.13/whatsnew/3.13.html#pep-594-dead-batteries-and-other-module-removals