Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff fails to run (old version installed with requirements.txt) #34

Closed
rngadam opened this issue Oct 24, 2023 · 1 comment · Fixed by #43
Closed

ruff fails to run (old version installed with requirements.txt) #34

rngadam opened this issue Oct 24, 2023 · 1 comment · Fixed by #43
Assignees
@vivalareda

Comments

@rngadam
Copy link
Contributor

rngadam commented Oct 24, 2023 •
edited
Loading

In this run:

https://github.com/ai-cfia/louis-db/actions/runs/6632241075

Lint fails because an older version is specified in requirements.txt (?)

ruff==0.0.280

image

latest ruff is 0.1.2 and does include --output-format:

https://docs.astral.sh/ruff/configuration/

probably should not specify a ruff version at all in requirements.txt?

@redat97 have a look
@rngadam rngadam mentioned this issue Oct 25, 2023
Open
@rngadam
Copy link
Contributor Author

rngadam commented Nov 3, 2023

@redat97 can you have a look? preventing us from linting.

vivalareda added a commit that referenced this issue Nov 3, 2023
@vivalareda
issue #34: remove ruff version from requirements
d517010
vivalareda added a commit that referenced this issue Nov 3, 2023
@vivalareda
issue #34: changed on push branch
49349b8
vivalareda added a commit that referenced this issue Nov 3, 2023
@vivalareda
issue #34: change trigger branch
4c96ba9
@vivalareda vivalareda mentioned this issue Nov 3, 2023
Merged
@vivalareda vivalareda linked a pull request Nov 3, 2023 that will close this issue
Fixes #34: ruff fails to run (old version installed with requirements.txt) #43
Merged
@rngadam rngadam mentioned this issue Nov 3, 2023
Merged
@github-project-automation github-project-automation bot moved this to Done in DevSecOps Nov 3, 2023
@vivalareda vivalareda removed this from DevSecOps Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vivalareda vivalareda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #34: ruff fails to run (old version installed with requirements.txt) ai-cfia/ailab-db
2 participants
@rngadam @vivalareda