Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #66 : Clean up docker helper for loading #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #66 : Clean up docker helper for loading #68

wants to merge 1 commit into from

Conversation

melanie-fressard
Copy link
Contributor

issue #66

@melanie-fressard melanie-fressard self-assigned this Dec 6, 2023
@melanie-fressard melanie-fressard linked an issue Dec 6, 2023 that may be closed by this pull request
Clean up docker helper for loading #66
Open
rngadam
rngadam suggested changes Dec 9, 2023
View reviewed changes
bin/Dockerfile
RUN apk add && apk add postgresql-client

# Copy the entry point script to the root directory
COPY bin/docker-entrypoint.sh /entrypoint.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested that it builds? because this relative reference is not updated.

any changes should come with testing, manual or automated

@rngadam rngadam removed their assignment Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rngadam rngadam rngadam requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up docker helper for loading
2 participants
@melanie-fressard @rngadam