Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate llamaindex search in the accuracy testing #16

Merged

Conversation

ibrahim-kabir
Copy link
Collaborator

@ibrahim-kabir ibrahim-kabir commented Apr 3, 2024

Summary

Enhance the accuracy testing by incorporating LlamaIndex Search. The tasks include adding LlamaIndex Search, tables for top results, and caching to Bing Search for improved performance.

Tasks

  • Add LlamaIndex Search
  • Add tables for top results
  • Add cache to Bing Search
  • Update the documentation

Closes

closes #15

Acceptance Criteria

  • LlamaIndex Search functionality is successfully integrated
  • Tables displaying top results are visible and functional
  • Bing Search performance improves with the addition of caching

@ibrahim-kabir ibrahim-kabir requested review from rngadam, leejaeka, cfiaGeetika and a team April 3, 2024 19:23
@ibrahim-kabir ibrahim-kabir self-assigned this Apr 3, 2024
@ibrahim-kabir ibrahim-kabir linked an issue Apr 3, 2024 that may be closed by this pull request
2 tasks
finesse/accuracy_functions.py Outdated Show resolved Hide resolved
finesse/accuracy_functions.py Outdated Show resolved Hide resolved
finesse/accuracy_functions.py Outdated Show resolved Hide resolved
finesse/bing_search.py Outdated Show resolved Hide resolved
finesse/scripts/xlsx_converter_json.py Outdated Show resolved Hide resolved
Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

for page in response_pages:
response_url.append(page.get("url"))
accuracy_result = calculate_accuracy(response_url, expected_url)
time_taken = round(response.elapsed.total_seconds()*1000,3)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space missing after comma

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ibrahim-kabir ibrahim-kabir merged commit 9d8d72b into main Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants