Add ADR for adopting Styled Components as a global styling strategy across CFIA projects #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cross CFIA projects #92
rngadam
suggested changes
Jan 17, 2024
There was a problem hiding this comment.
@CFIALeronB preferable to keep this as draft until you've fixed the failed checks
k-allagbe
requested changes
Jan 30, 2024
There was a problem hiding this comment.
We should consider keeping both as CSS is still so prevalent in the industry: https://w3techs.com/technologies/details/ce-css
| - Pros: Familiarity and simplicity. | ||
| - Cons: Scalability issues, potential naming conflicts, and less dynamic styling capabilities. | ||
|
|
||
| 2. **Other CSS-in-JS Libraries:** |
There was a problem hiding this comment.
We should probably detail few of those.
| **Link to Reference Materials:** | ||
| - [Styled Components Official Documentation](https://styled-components.com/docs) | ||
|
|
||
| ## Alternatives Considered |
There was a problem hiding this comment.
Should also show the pro and cons for Styled Components.
|
@CFIALeronB one check fails and some comments from @k-allagbe need follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an ADR documenting the adoption of Styled Components as the standard for CSS styling across all CFIA projects, outlining benefits, decision rationale, and comparisons with alternatives.
#92