Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6 update repo description to emphasize prototyping #10

Merged
merged 17 commits into from
Apr 10, 2024
Merged

6 update repo description to emphasize prototyping #10

merged 17 commits into from
Apr 10, 2024

Conversation

SamuelPelletierEvraire
Copy link
Contributor

@SamuelPelletierEvraire SamuelPelletierEvraire commented Apr 10, 2024 •
edited
Loading

Tasks

  • Update the repository description in the README file.
  • Replace any references to "frontend" with "prototyping".
  • Correcting the error generate by the workflow.
  • Update the README file and add a description.

Acceptance Criteria

  • The README file clearly states that the repository is for prototyping.
  • All instances of "frontend" in the description have been changed to "prototyping".
  • All the error from the workflow are resolve.
  • The readme file contain a description of the harvester project.

@SamuelPelletierEvraire SamuelPelletierEvraire linked an issue Apr 10, 2024 that may be closed by this pull request
Update Repo Description to Emphasize Prototyping #6
Closed
@SamuelPelletierEvraire SamuelPelletierEvraire requested review from a team April 10, 2024 14:57
@SamuelPelletierEvraire SamuelPelletierEvraire linked an issue Apr 10, 2024 that may be closed by this pull request
Missing Project Description in README #3
Closed
@SamuelPelletierEvraire SamuelPelletierEvraire changed the title 6 update repo description to emphasize prototyping 10 update repo description to emphasize prototyping Apr 10, 2024
@SamuelPelletierEvraire SamuelPelletierEvraire changed the title 10 update repo description to emphasize prototyping 6 update repo description to emphasize prototyping Apr 10, 2024
MaxenceGui
MaxenceGui reviewed Apr 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rngadam
rngadam suggested changes Apr 10, 2024
View reviewed changes
Copy link

@rngadam rngadam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forward slash instead of \\ for file paths

SamuelPelletierEvraire
SamuelPelletierEvraire commented Apr 10, 2024
View reviewed changes
Copy link
Contributor Author

@SamuelPelletierEvraire SamuelPelletierEvraire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rngadam done

SonOfLope
SonOfLope suggested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@SonOfLope SonOfLope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good description of the project. I added a comment on providing reference for gemini but otherwise its very clear and concise.

README.md Show resolved Hide resolved
ThomasCardin
ThomasCardin approved these changes Apr 10, 2024
View reviewed changes
README.md Show resolved Hide resolved
rngadam
rngadam suggested changes Apr 10, 2024
View reviewed changes
Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is up with the checks and they are not running:

image

app.py Show resolved Hide resolved
@SamuelPelletierEvraire SamuelPelletierEvraire merged commit 648847c into main Apr 10, 2024
7 checks passed
@SamuelPelletierEvraire SamuelPelletierEvraire deleted the 6-update-repo-description-to-emphasize-prototyping branch May 16, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxenceGui MaxenceGui MaxenceGui approved these changes

@SonOfLope SonOfLope SonOfLope approved these changes

@ThomasCardin ThomasCardin ThomasCardin approved these changes

@rngadam rngadam rngadam approved these changes

Assignees

@SamuelPelletierEvraire SamuelPelletierEvraire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Repo Description to Emphasize Prototyping Missing Project Description in README
5 participants
@SamuelPelletierEvraire @rngadam @ThomasCardin @SonOfLope @MaxenceGui