Skip to content

Conversation

@rmccorm4
Copy link
Contributor

@rmccorm4 rmccorm4 commented May 28, 2025

Overview:

Quick fix fo build failure introduced here: https://github.com/ai-dynamo/dynamo/pull/1231/files

#31 [build 13/21] RUN uv pip install genai-perf==0.0.13
#31 0.642 /bin/bash: line 1: uv: command not found

Current TRTLLM container doesn't activate venv by default like the VLLM container does due to various issues around pytorch/trtllm install in the past, so doing a normal pip install outside the venv makes genai-perf readily available when entering the container.

Long term fix is to polish up the TRTLLM Dockerfile to use uv pip everywhere if all issues with PyTorch/TRTLLM dependencies are now resolved with respect to venv usage.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the package installation command to ensure proper installation of the required Python package during container build.

@copy-pr-bot
Copy link

copy-pr-bot bot commented May 28, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 28, 2025

Walkthrough

A correction was made to the Dockerfile for the TensorRT LLM container by removing an incorrect "uv" prefix from the pip install command for the genai-perf package. The command now properly uses pip install to ensure correct package installation.

Changes

File Change Summary
container/Dockerfile.tensorrt_llm Fixed pip install command by removing erroneous "uv" prefix

Poem

In the Dockerfile's gentle night,
A rogue "uv" took flight.
Now pip installs with grace,
genai-perf finds its place.
Rabbits cheer, the build runs true—
Clean commands, and packages too!
🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8cc1361 and 309a22a.

📒 Files selected for processing (1)
  • container/Dockerfile.tensorrt_llm (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test - vllm
🔇 Additional comments (1)
container/Dockerfile.tensorrt_llm (1)

169-169: Fixes the uv: command not found error by removing the invalid prefix
Changing RUN uv pip install genai-perf==$GENAI_PERF_VERSION to RUN pip install genai-perf==$GENAI_PERF_VERSION correctly invokes pip.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rmccorm4 rmccorm4 enabled auto-merge (squash) May 29, 2025 00:11
@rmccorm4 rmccorm4 merged commit 8941db8 into main May 29, 2025
10 checks passed
@rmccorm4 rmccorm4 deleted the rmccormick/fix_trtllm_build_simple branch May 29, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants