-
Notifications
You must be signed in to change notification settings - Fork 691
build: Fix 'uv: command not found' in TRTLLM build #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA correction was made to the Dockerfile for the TensorRT LLM container by removing an incorrect "uv" prefix from the pip install command for the Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Overview:
Quick fix fo build failure introduced here: https://github.com/ai-dynamo/dynamo/pull/1231/files
Current TRTLLM container doesn't activate venv by default like the VLLM container does due to various issues around pytorch/trtllm install in the past, so doing a normal
pip installoutside the venv makesgenai-perfreadily available when entering the container.Long term fix is to polish up the TRTLLM Dockerfile to use
uv pipeverywhere if all issues with PyTorch/TRTLLM dependencies are now resolved with respect tovenvusage.Summary by CodeRabbit