ci: Add args to run.sh

[pvijayakrish]

Overview:

Add --workdir and --runtime flags to run.sh.

Summary by CodeRabbit

• New Features
  • Added options to customize the Docker runtime and working directory when running containers.
  • Users can now specify --runtime and --workdir command-line options for greater flexibility.
• Documentation
  • Updated help messages to include information about the new options.

[coderabbitai]

Walkthrough

The script container/run.sh is updated to support two new configurable parameters: RUNTIME and WORKDIR, which can be set via new command-line options. The Docker run command now conditionally includes these options, and the help message is updated to reflect the new functionality.

Changes

File(s)	Change Summary
container/run.sh	Added --runtime and --workdir options, corresponding variables, updated Docker invocation, and enhanced help message.

Poem

🐰
New options hop into the script—
RUNTIME and WORKDIR, tightly gripped.
Now containers run with custom flair,
Choose your runtime, set your lair!
Help now tells you all you need,
The bunny’s work is done—indeed!
🥕

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f79d79b and aea0bbe.

📒 Files selected for processing (1)

• container/run.sh (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• container/run.sh

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build and Test - vllm

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

container/run.sh (4)

43-44: Initialize default RUNTIME and WORKDIR variables
The script sets sensible defaults for the Docker runtime and working directory. Consider allowing these to be overridden via environment variables before falling back to defaults or marking them as read-only if immutable.

---

282-284: Clear RUNTIME when GPUs are disabled
Good addition, though for consistency you could normalize $GPUS once (e.g., ${GPUS^^}) rather than comparing both cases explicitly.

---

302-304: Update help text for new options
The help entries are accurate but the description for --runtime could be more descriptive (e.g. “set Docker runtime plugin: nvidia or none”). Align indentation with other flags.

---

329-329: Inject --runtime flag into docker run invocation
Using parameter expansion is clean; consider quoting the runtime value (--runtime "$RUNTIME") to avoid issues if the variable ever contains spaces.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98708c4 and f79d79b.

📒 Files selected for processing (1)

• container/run.sh (6 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

container/run.sh (1)

container/build.sh (1)

• missing_requirement (358-360)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Mirror Repository to GitLab
• GitHub Check: Build and Test - vllm

🔇 Additional comments (3)

container/run.sh (3)

102-109: Correctly parse --runtime CLI option
The new case branch handles presence and absence of the runtime argument consistently with other options. Good use of missing_requirement for error handling.

---

118-125: Correctly parse --workdir CLI option
This branch follows the established pattern for options with required values and integrates seamlessly.

---

336-336: Use configurable working directory
Replacing the hardcoded path with $WORKDIR is correct and properly quoted.