-
Notifications
You must be signed in to change notification settings - Fork 703
chore: Default to pytorch backend in trtllm worker #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new key-value pair, Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
launch/dynamo-run/src/subprocess/trtllm_inc.py (1)
355-355: LGTM! Backend default aligns with PyTorch-first strategy.The change successfully defaults to PyTorch backend as intended, supporting the DS R1 requirements and kv events/metrics functionality. Users can still override via extra engine args if needed.
Note: This change makes the condition
"backend" not in arg_mapat line 378 effectively dead code since backend is now always present. Consider documenting this as a breaking change if users were relying on different default backend behavior.Consider simplifying the validation logic at lines 378-384 since backend is now always set:
# Only pytorch backend is supported for now to publish events and metrics. -if "backend" not in arg_map: - arg_map["backend"] = "pytorch" -elif arg_map["backend"] != "pytorch": +if arg_map["backend"] != "pytorch": logging.error( "Only pytorch backend is supported for now to publish events and metrics." ) sys.exit(1)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
launch/dynamo-run/src/subprocess/trtllm_inc.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Build and Test - vllm
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: pre-merge-rust (.)
- GitHub Check: pre-merge-rust (lib/runtime/examples)
Overview:
Default to pytorch backend in TRTLLM worker if left unspecified.
trtllm-llmapi-launchcurrentlyPower users can override backend field in extra engine args YAML if needed.
Summary by CodeRabbit