-
Notifications
You must be signed in to change notification settings - Fork 690
ci: add github workflow to close stale issues (bugs) and PRs #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
""" WalkthroughA new GitHub Actions workflow file has been added to automate the process of marking and closing stale issues and pull requests. The workflow runs daily, applies inactivity rules, posts warning messages, closes items after further inactivity, and deletes branches for stale pull requests. Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/stale_cleaner.yml (2)
13-17: Clarify time zone handling in cron schedule
The comment says “1:30 AM PST,” but GitHub Actions cron expressions run in UTC. Consider updating the comment to reflect UTC (09:30 UTC) or note any daylight-saving implications (PDT vs PST).
37-37: Add newline at end of file
Ensure the file ends with a newline to satisfy YAML linting and POSIX standards.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 37-37: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/stale_cleaner.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/stale_cleaner.yml
[warning] 30-30: wrong indentation: expected 10 but found 12
(indentation)
[error] 37-37: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
.github/workflows/stale_cleaner.yml (3)
1-11: License header and context comments look good
The SPDX identifiers and explanatory comments clearly document the workflow’s purpose and licensing.
18-23: Permissions are appropriately scoped
The workflow grants only the necessarywritepermissions for actions, contents (for branch deletion), issues, and pull-requests.
24-27: Job definition is clear and minimal
Thestalejob is correctly configured to run onubuntu-latestwith a single step invoking the stale action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/stale_cleaner.yml (2)
28-29: Explicitly supplyrepo-tokento the action.
Althoughactions/staledefaults to${{ secrets.GITHUB_TOKEN }}, it's best practice to declare it explicitly for clarity and future compatibility.Apply this diff:
- - uses: actions/stale@v9 - with: + - uses: actions/stale@v9 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.'
37-37: Add newline at end of file.
A trailing newline is required by POSIX and some linters.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 37-37: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/stale_cleaner.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/stale_cleaner.yml
[error] 37-37: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and Test - vllm
🔇 Additional comments (4)
.github/workflows/stale_cleaner.yml (4)
1-11: The SPDX header and descriptive comments are clear and correctly present.
13-17: Verify cron schedule uses UTC vs PST.
GitHub Actions cron triggers always run in UTC, so30 9 * * *fires at 09:30 UTC (1:30 AM PST). This will shift to 2:30 AM PDT during daylight-saving. Please confirm this aligns with the intended local schedule.
18-23: The job-level permissions for actions, contents, issues, and pull-requests are correctly scoped for this workflow.
24-27: Thejobs.staleand its runner configuration are straightforward and have no issues.
|
LGTM! |
add github workflow to automatically close stale issues (bugs) and PRs
closes: OPS-199
Summary by CodeRabbit