-
Notifications
You must be signed in to change notification settings - Fork 693
docs: Add GitHub Pages deployment to dynamo.github.io for release branches #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…- Deploy to version-specific subdirectories with CI_TOKEN
Signed-off-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
…b.io instead of dynamo.github.io
…y to private ai-dynamo/dynamo-docs repository with internal visibility
… with debug steps
Signed-off-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
Signed-off-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
Signed-off-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
Signed-off-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
.github/workflows/generate-docs.yml
Outdated
| external_repository: ai-dynamo/dynamo-docs | ||
| publish_branch: main | ||
| publish_dir: ./dynamo-docs | ||
| destination_dir: ${{ steps.extract_branch.outputs.branch }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ${{ github.ref_name }} should work, for branch name. Can remove the extra step to extract branch name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor suggested this approach. I can try to change and see if the simpler ${{ github.ref_name }} works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! remove name: Extract branch name step too ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
Signed-off-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
This PR adds deployment automation to deploy documentation to dynamo.github.io repository when pushing to release branches.
Walkthrough
A new
deployjob was added to the GitHub Actions workflow for documentation generation. This job depends on thebuild-docsjob, runs only onreleasebranches, and deploys generated documentation to an external repository using a GitHub Pages action, with deployment details dynamically set from the branch and commit.Changes
deployjob that downloads the docs artifact, extracts the branch name, and deploys documentation to an external repo using GitHub Pages.Sequence Diagram(s)
sequenceDiagram participant GitHub Actions participant build-docs Job participant deploy Job participant ai-dynamo/dynamo.github.io Repo GitHub Actions->>build-docs Job: Trigger on push to release branch build-docs Job-->>GitHub Actions: Generate and upload docs artifact GitHub Actions->>deploy Job: Start if build-docs succeeds deploy Job->>deploy Job: Download docs artifact deploy Job->>deploy Job: Extract branch name from GITHUB_REF deploy Job->>ai-dynamo/dynamo.github.io Repo: Deploy docs via gh-pages actionPoem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.Other keywords and placeholders
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed.@coderabbitai summaryto generate the high-level summary at a specific location in the PR description.@coderabbitaianywhere in the PR title to generate the title automatically.Documentation and Community