fix: Fix sample disagg config for trtllm standalone

[tanmayv25]

Overview:

The context worker needs the overlap scheduler to be disabled.

Summary by CodeRabbit

• New Features
  • Added a new configuration option to disable the overlap scheduler in the settings file.

[coderabbitai]

Walkthrough

A new configuration option, disable_overlap_scheduler: true, was added to the sample.yaml file for the trtllm_config in the subprocess directory. This option is placed near existing backend settings, with no other changes to the file's structure or content.

Changes

File(s)	Change Summary
launch/dynamo-run/src/subprocess/trtllm_config/sample.yaml	Added disable_overlap_scheduler: true to config file

Possibly related PRs

• fix: Update breaking change to enable_overlap_scheduler field from TRTLLM commit b4e5df0e #1310: Adds the disable_overlap_scheduler option to the YAML config, mirroring the configuration field change in this PR.
• feat: Enable disagg support in trtllm standalone script  #1355: Introduces the YAML config file and code for disaggregated serving modes, which is modified in this PR.

Poem

A sprinkle of YAML, a toggle so neat,
Overlap scheduler now takes a backseat.
With true in its name, the config’s complete—
Rabbits rejoice, for clarity’s a treat!
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

launch/dynamo-run/src/subprocess/trtllm_config/sample.yaml (1)

16-21: Document the new flag in the header comments.

Consider extending the sample config’s descriptive comments to explain what disable_overlap_scheduler does, so users understand its impact when tweaking this file.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49b7e93 and fbd2407.

📒 Files selected for processing (1)

• launch/dynamo-run/src/subprocess/trtllm_config/sample.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: pre-merge-rust (lib/runtime/examples)
• GitHub Check: pre-merge-rust (lib/bindings/python)
• GitHub Check: pre-merge-rust (.)
• GitHub Check: Build and Test - vllm

🔇 Additional comments (2)

launch/dynamo-run/src/subprocess/trtllm_config/sample.yaml (2)

22-23: Correct placement of disable_overlap_scheduler flag.

The new option is properly added at the top level alongside the existing backend setting and will disable the overlap scheduler as intended.

---

22-24: Verify support in config parser.

Ensure that the code loading this YAML recognizes and respects the disable_overlap_scheduler field. You can search the repo for references to confirm parser handling:

#!/bin/bash
# Search for references to disable_overlap_scheduler in the codebase
rg -n "disable_overlap_scheduler"